Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CI faster #157

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Make CI faster #157

wants to merge 5 commits into from

Conversation

y26805
Copy link

@y26805 y26805 commented Oct 12, 2022

Currently build is quite slow (> 8m), and if a test fails we need to re-try the entire job.

image

This PR aims to make builds faster, by

  • checking in poetry.lock for faster package resolution
  • caching
  • parallelizing tests
  • separating build/test steps in the workflow (to make retries easier and faster)
    image

@ojii
Copy link
Contributor

ojii commented Oct 12, 2022

  • checking in poetry.lock for faster package resolution

I do not like this for libraries. CI should run against the latest versions

@ojii
Copy link
Contributor

ojii commented Oct 12, 2022

I wonder if we should just port this to GHA like I did for aiodynamo. There I also made it so poetry only locks in one step that is re-used by the rest.

@y26805
Copy link
Author

y26805 commented Oct 12, 2022

  • checking in poetry.lock for faster package resolution

I do not like this for libraries. CI should run against the latest versions

yeah thats fair

@y26805
Copy link
Author

y26805 commented Oct 12, 2022

I wonder if we should just port this to GHA like I did for aiodynamo. There I also made it so poetry only locks in one step that is re-used by the rest.

yeah GHA could work too.. whichever CI tool we use though, think we should separate out browser tests (relatively flaky) vs other tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants