Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite 3.35.5 #75515

Closed
wants to merge 1 commit into from
Closed

sqlite 3.35.5 #75515

wants to merge 1 commit into from

Conversation

Moisan
Copy link
Member

@Moisan Moisan commented Apr 19, 2021

Created with brew bump-formula-pr.

This was referenced Apr 20, 2021
Merged
Merged
Merged
Merged
Merged
@Moisan
Copy link
Member Author

Moisan commented Apr 21, 2021 •
edited
Loading

Tests failing:

@carlocab
Copy link
Member

opencascade is just on Mojave, and it's been failing tests there for a while now.

@carlocab
Copy link
Member

carlocab commented Apr 23, 2021 •
edited
Loading

Rebased to pull in some more fixes (e.g. cash-cli deprecated in #75709), plus the ARM runner crashed for some reason anyway.

@carlocab
Copy link
Member

Mojave:

Error: 8 failed steps!
brew bottle --verbose --json sqlite --only-json-tab
brew test --retry --verbose caffe
brew test --retry --verbose global
brew test --retry --verbose hyperkit
brew test --retry --verbose opencascade
brew test --retry --verbose swift
brew test --retry --verbose wasm-pack
brew test --retry --verbose youtube-dlc

Other nodes look similar, sans the bottle failure. Other than the bottle failure I'd say this would've been good to merge.

@carlocab carlocab mentioned this pull request Apr 26, 2021
Closed
5 tasks
carlocab
carlocab approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bottle failure should be fixed. Restarting CI, and barring any more weirdness, this should be good to merge when it's done.

@carlocab
Copy link
Member

llvm@11: #76030

@carlocab
Copy link
Member

Failures look nearly identical to #76174, so I doubt they're caused by the version bump. Merging.

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@Moisan Moisan deleted the bump-sqlite-3.35.5 branch May 1, 2021 14:08
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Moisan @carlocab @BrewTestBot