Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce Flake for development and builds #2121

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shymega
Copy link

@shymega shymega commented Sep 11, 2024

This PR introduces a Nix flake, allowing for InfiniTime to be built as a Flake, including a FHS development environment.

It's derived from #1850 and
icewind1991/infinitime-builder@c57c57f.

We also introduce flake-compat, allowing for non-Flake Nix mahcines to use the project as-is, both for building (default.nix), and development (shell.nix).

Additionally, we introduce .envrc, meaning that with direnv, the Nix Flake is activated automatically.

Fixes #1850.

@shymega
Copy link
Author

shymega commented Sep 11, 2024

I'm keeping this as a draft for now, because I want to check with the
InfiniTime maintainers, that I'm using the correct nRF SDK, and GCC toolchain.

I also wanted to ask if the .envrc is acceptable as well.

Thanks.

@shymega
Copy link
Author

shymega commented Sep 11, 2024

We also need to document the Flake, and possibly add CI.

I can add the CI workflows to a new PR if needed. However, I'm not sure how
documentation works in this project.

Copy link

Build checks have not completed. Possible reasons for this are:

  1. The checks need to be approved by a maintainer
  2. The branch has conflicts
  3. The firmware build has failed

@shymega shymega force-pushed the shymega-feat/nix-flake branch 2 times, most recently from 46daf79 to a9a3679 Compare September 14, 2024 13:27
@shymega shymega force-pushed the shymega-feat/nix-flake branch 7 times, most recently from c96db08 to 7606e37 Compare October 13, 2024 14:40
This PR introduces a Nix flake, allowing for InfiniTime to be built as a
Flake, including a FHS development environment.

It's derived from InfiniTimeOrg#1850 and
icewind1991/infinitime-builder@c57c57f.

We also introduce `flake-compat`, allowing for non-Flake Nix mahcines to
use the project as-is, both for building (`default.nix`), and
development (`shell.nix`).

Additionally, we introduce `.envrc`, meaning that with `direnv`, the Nix
Flake is activated automatically.

Fixes InfiniTimeOrg#1850.

Signed-off-by: Dom Rodriguez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant