Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fallback to friday instead of two days before #414

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Fallback to friday instead of two days before #414

wants to merge 1 commit into from

Conversation

kewne
Copy link
Contributor

@kewne kewne commented Apr 13, 2024 •
edited by keilw
Loading

Fixed an issue in the test where it was going back two days on Saturday, which landed on Thursday instead of Friday.

This change is Reviewable

@keilw keilw self-requested a review April 20, 2024 15:57
@keilw keilw added this to the 1.4.5 milestone Apr 20, 2024
keilw
keilw reviewed Sep 7, 2024
View reviewed changes
Copy link
Member

@keilw keilw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this sure the Friday before the weekend, or the next Friday, also on Sundays?
Could you test it with unit tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keilw keilw keilw left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Backlog
Status: In Progress
Milestone
1.4.5
Development

Successfully merging this pull request may close these issues.
2 participants
@kewne @keilw