BIP-119.2 Properly Trim CTV Flags w/ 21/33 byte version

JeremyRubin · May 6, 2024 · 144d617 · 144d617
1 parent 44f0998
commit 144d617
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/bip-0119.2.mediawiki b/bip-0119.2.mediawiki
@@ -116,7 +116,7 @@ def execute_bip_119_v2(self):
             self.context.precomputed_ctv_data = self.context.tx.get_default_check_template_precomputed_data()
 
         # If the hashes do not match, return error
-        if stack[-1] != ripemd(sha256(self.context.tx.get_default_check_template_hash(self.context.nIn, self.context.precomputed_ctv_data) + sha256(stack[-2]))):
+        if stack[-1][:-1] != ripemd(sha256(self.context.tx.get_default_check_template_hash(self.context.nIn, self.context.precomputed_ctv_data) + sha256(stack[-2]))):
             return self.errors_with(errors.script_err_template_mismatch)
 
         return self.return_as_nop()
@@ -142,7 +142,7 @@ def execute_bip_119_v2(self):
             self.context.precomputed_ctv_data = self.context.tx.get_default_check_template_precomputed_data()
 
         # If the hashes do not match, return error
-        if stack[-1] != sha256(self.context.tx.get_default_check_template_hash(self.context.nIn, self.context.precomputed_ctv_data) + sha256(stack[-2])):
+        if stack[-1][:-1] != sha256(self.context.tx.get_default_check_template_hash(self.context.nIn, self.context.precomputed_ctv_data) + sha256(stack[-2])):
             return self.errors_with(errors.script_err_template_mismatch)
 
         return self.return_as_nop()