Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix const definition regex to match symbols with underscores etc. #197

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Fix const definition regex to match symbols with underscores etc. #197

merged 2 commits into from
Jul 12, 2023

Conversation

non-Jedi
Copy link
Contributor

Regex introduced in #177 doesn't match e.g. const my_symbol_with_underscores = 0 or x = const y = 1.

tpapp
tpapp reviewed Jul 12, 2023
View reviewed changes
julia-mode.el Outdated Show resolved Hide resolved
tpapp
tpapp approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@tpapp tpapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tpapp tpapp merged commit 7a8c868 into JuliaEditorSupport:master Jul 12, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpapp tpapp tpapp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@non-Jedi @tpapp