Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store entry names as ranges. #20

Merged
merged 4 commits into from
Jul 9, 2023
Merged

Store entry names as ranges. #20

merged 4 commits into from
Jul 9, 2023

Conversation

nhz2
Copy link
Member

@nhz2 nhz2 commented Jul 9, 2023

Switching from views to ranges significantly speeds up garbage collection times
if there are many zip archives being read.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 92.10% and project coverage change: -0.35 ⚠️

Comparison is base (7ca708e) 96.60% compared to head (90257cb) 96.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   96.60%   96.25%   -0.35%     
==========================================
  Files           6        6              
  Lines         765      775      +10     
==========================================
+ Hits          739      746       +7     
- Misses         26       29       +3     
Impacted Files Coverage Δ
src/types.jl 100.00% <ø> (ø)
src/writer.jl 98.79% <90.00%> (-0.30%) ⬇️
src/reader.jl 95.02% <92.85%> (-0.40%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nhz2 nhz2 merged commit 4522a63 into main Jul 9, 2023
3 checks passed
@nhz2 nhz2 deleted the name-range branch July 9, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants