Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 32 bit to CI #21

Merged
merged 4 commits into from
Jul 11, 2023
Merged

Add 32 bit to CI #21

merged 4 commits into from
Jul 11, 2023

Conversation

nhz2
Copy link
Member

@nhz2 nhz2 commented Jul 11, 2023

Adds 32-bit systems to the CI tests.

Also adds some more explicit use Int64, and more careful checking for overflow.

I still need to add tests for writing and reading files larger than 4GB on 32-bit systems.

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10 🎉

Comparison is base (4522a63) 96.64% compared to head (e6fe73b) 96.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   96.64%   96.75%   +0.10%     
==========================================
  Files           6        6              
  Lines         775      800      +25     
==========================================
+ Hits          749      774      +25     
  Misses         26       26              
Impacted Files Coverage Δ
src/reader.jl 95.78% <100.00%> (+0.26%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nhz2 nhz2 merged commit 30e32a0 into main Jul 11, 2023
5 checks passed
@nhz2 nhz2 deleted the test-32bit branch July 11, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants