Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc: use xdg-open for the show in finder command #2584

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Defman21
Copy link
Contributor

@Defman21 Defman21 commented May 4, 2017

Signed-off-by: Defman21 [email protected]

Fixed #250

@bilelmoussaoui
Copy link

If you do use xdg-open; there's no need to keep the Nautilus/Doplhin options. As every Linux DE out there follows free-desktop standards and so by using xdg-open it will open the default file manager no matter which DE you're using

@Naatan
Copy link
Member

Naatan commented Jun 17, 2017

Why did you remove the fallbacks? Those are still very relevant.

Edit: just read @bil-elmoussaoui 's response. I don't agree with this, this is Linux. We should not make assumptions,

@bilelmoussaoui
Copy link

bilelmoussaoui commented Jun 17, 2017

@Naatan
Can you please give me an example where xdg-open doesn't work? xdg-open just uses xdg-query to get the default application for the mime type inode/directory. Which is work on every Linux system out there?
Edit:

  • i might use gnome with Nemo instead of Nautilus or whatever stuff i want...

@Defman21
Copy link
Contributor Author

Defman21 commented Jun 17, 2017

i might use gnome with Nemo instead of Nautilus or whatever stuff i want...

xdg-open would be called first so as long as you have it on your $PATH, Komodo would call it and if it does not exist, call something else. (e.g. Nautilus).

@Naatan those 2 file managers does not cover most popular DE's. I think it's better to add a list of some popular file managers and search for them on the PATH rather than doing if-else for DE's. What do you think? :)

UPD: oops, that was in the initial fix. I'll add more managers and revert my latest change tomorrow so we'd have some fallbacks.

@Naatan
Copy link
Member

Naatan commented Jun 17, 2017

Can you please give me an example where xdg-open doesn't work? xdg-open just uses xdg-query to get the default application for the mime type inode/directory. Which is work on every Linux system out there?

It's not about it not working, it's about it being available. There is no reason to not have a fallback, it costs us nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants