Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unity Menubar support #868

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mystic-Mirage
Copy link

@Mystic-Mirage Mystic-Mirage commented Nov 14, 2015

Hello!

Since Komodo Edit 8.5 the patching of Mozilla is the only way to support Unity Menubar integration due to Ubuntu upstream changes.

During two years of using this patch there are no problems found in other DEs. Tested on Gnome, Gnome Flashback, KDE, XFCE, LXDE, Cinnamon and Mint.

The unity-menubar.patch used unchanged from code.launchpad.net/~mozillateam/firefox/firefox-trunk.head. It released under Mozilla Public License version 2.0.

Maybe it is time to integrate this patch to Komodo Edit mainline? And it is the way to integrate this patch to Komodo IDE for those who need it.


This change is Reviewable

@Defman21
Copy link
Contributor

👍 for this PR. Really want to see the appmenu in the menubar of Unity DE.

@Naatan
Copy link
Member

Naatan commented Nov 16, 2015

This is great! Thanks @Mystic-Mirage! I won't integrate it right away as some testing will be required, but I'll definitely ensure we try this for Komodo 10.

@Naatan Naatan self-assigned this Nov 16, 2015
@Naatan Naatan added this to the 10.0 milestone Nov 16, 2015
@mitchell-as mitchell-as assigned mitchell-as and unassigned Naatan Feb 8, 2016
@mitchell-as
Copy link
Contributor

The effects of this patch will not show up in Komodo 10's new UI, so I'm closing this PR. Thanks for your efforts though!

@garak
Copy link

garak commented May 20, 2016

If you can consider to re-open this issue, I can say that I'm using Komodo 10 with global menu.
I just applied files extracted from @Mystic-Mirage PPA over my Komodo IDE 10 installation.
komodoidemenu

@th3coop
Copy link
Member

th3coop commented May 20, 2016

@th3coop th3coop reopened this May 20, 2016
@Defman21
Copy link
Contributor

You'd change the milestone.

@awilkins
Copy link

For reference, which files do you need to merge from the patched "Edit" .deb to get it working in the IDE?

@garak
Copy link

garak commented Aug 12, 2016

@awilkins
Copy link

awilkins commented Aug 12, 2016 via email

@garak
Copy link

garak commented Aug 12, 2016

If you got different instructions to get it working, what about sharing them?

@Defman21
Copy link
Contributor

@mitchell-as
Copy link
Contributor

I've applied this patch and tested in Ubuntu. Here are my initial impressions:

  • Alt+F or any other menubar shortcut no longer works out of the box. The hamburger menu is the only way to get menu access.
  • Right-click > Show Menubar on the titlebar does nothing but hide the hamburger menu. I don't have access to any menu at this point.
  • I must enable native window decorations in order to be able to Alt+F or similar to get a menu.

I spoke with @Naatan about this and he wants to see if he can make this work more intuitively. Until he manages to do so, I cannot recommend merging this PR. Assigning to him in the meantime.

@mitchell-as mitchell-as assigned Naatan and unassigned mitchell-as Sep 27, 2016
@Defman21
Copy link
Contributor

Alt+F or any other menubar shortcut no longer works out of the box. The hamburger menu is the only way to get menu access.

Works fine for me. When I hold Alt, global menu items highlights accessible keys. (Alt+F opens File menu).

I must enable native window decorations in order to be able to Alt+F or similar to get a menu.

Works for me in both situations.

Right-click > Show Menubar on the titlebar does nothing but hide the hamburger menu. I don't have access to any menu at this point.

Yep, this one doesn't work anymore.

However, I've applied this patch by copying some files from the global menu patch (from KomodoEdit PPA).. I assume this could give different results.

@mitchell-as
Copy link
Contributor

@Defman21 You're right that if you maximize the Komodo window, menu shortcuts work out of the box. I was starting in window'ed mode.

@Defman21
Copy link
Contributor

Defman21 commented Sep 27, 2016

Hmm, it works fine for me even in windowed mode. With native or without native decorations. We would need more testers for that.

@mitchell-as
Copy link
Contributor

Perhaps they are related to your custom patches then. I only have only applied the PR.

@Defman21
Copy link
Contributor

@Mystic-Mirage are there any changes between mine method of getting global menu support and directly applying this patch?

@Defman21
Copy link
Contributor

Btw I can test this patch but I don't know how (I've copied unity-menubar.patch to Komodo source/mozilla/patches-new/mozilla-35.0/gtk/). I have to python build.py distclean all?

@mitchell-as
Copy link
Contributor

@Defman21 Yes, that's it. And then sit tight for an hour or two :)

@Defman21
Copy link
Contributor

About 40 mins for me :) Thanks.

@Defman21
Copy link
Contributor

Huh, looks like python build.py all works fine. I don't have to re-download Mozilla core again.

@Naatan
Copy link
Member

Naatan commented Sep 27, 2016

I think you will need python build.py clean all. Otherwise it's using the cache and likely won't apply all the patches.

@Defman21
Copy link
Contributor

Okay, thanks.

@Mystic-Mirage
Copy link
Author

@Defman21 Hi! If you have copied only files listed bellow, there is no difference between methods because that patch affects only these files:

./mozilla/chrome/toolkit/content/global/xul.css
./mozilla/chrome/toolkit/content/global/bindings/popup.xml
./mozilla/greprefs.js
./mozilla/libxul.so

@Defman21
Copy link
Contributor

@mitchell-as were you using Docker for building?

@mitchell-as
Copy link
Contributor

@Defman21 No. Native Ubuntu 14.04.

@Defman21
Copy link
Contributor

Thanks. I've reported #2061 for that.

@Naatan Naatan modified the milestones: Perpetual, 11 Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants