Allow binary as a 'protocol' #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarrodchesney
approved these changes
Jan 28, 2017
|
Any chance to merge this? |
|
The diff looks simple enough to me. |
|
@MostAwesomeDude pretty please :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noVNC has removed support for base64 encoding in the latest release: novnc/noVNC@38781d9
This means that noVNC ends up sending the header "Sec-WebSocket-Protocol:binary", and vncAuthProxy/txWS can't deal with that because binary is not in the encoders/decoders dicts and txWS returns false from validateHeaders.