Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only remove output files for the current member in Variational.csh #310

Merged
merged 1 commit into from
May 28, 2024
Merged

Only remove output files for the current member in Variational.csh #310

merged 1 commit into from
May 28, 2024

Conversation

jim-p-w
Copy link
Collaborator

@jim-p-w jim-p-w commented May 28, 2024

Also remove output files from the dbOut directory in EnKF.csh

Description

Issue closed

Closes #(if applicable)

Tests completed

Tier 1:

  • 3dvar_OIE120km_WarmStart
  • 3denvar_OIE120km_IAU_WarmStart
  • 3dvar_OIE120km_ColdStart
  • 3dvar_O30kmIE60km_ColdStart
  • 3denvar_O30kmIE60km_WarmStart
  • eda_OIE120km_WarmStart (this tested the changes to Variational.csh)
  • getkf_OIE120km_WarmStart (this tested the changes to EnKF,csh)
  • ForecastFromGFSAnalysesMPT

Tier 2 (optional):

  • GenerateGFSAnalyses
  • GenerateObs

@jim-p-w
Only remove output files fot the current member in Variational.csh
a7d44a4 
Remove output files from the dbOut directory in EnKF.csh
@jim-p-w jim-p-w self-assigned this May 28, 2024
@jim-p-w jim-p-w mentioned this pull request May 28, 2024
Merged
10 tasks
@jim-p-w
Copy link
Collaborator Author

jim-p-w commented May 28, 2024

See issue #309 for what needs to be done for EnsembleOfVariational.csh (I haven't yet got a working test for that).

ibanos90
ibanos90 approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@ibanos90 ibanos90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @jim-p-w for providing this fix! I ran the tests and worked correctly.

@jim-p-w jim-p-w merged commit 3b098df into develop May 28, 2024
@jim-p-w jim-p-w deleted the maintenance/cleanup-fixes branch May 28, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibanos90 ibanos90 ibanos90 approved these changes

@amstokely amstokely amstokely approved these changes

@liujake liujake Awaiting requested review from liujake

@junmeiban junmeiban Awaiting requested review from junmeiban

@mos3r3n mos3r3n Awaiting requested review from mos3r3n

Assignees

@jim-p-w jim-p-w

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jim-p-w @ibanos90 @amstokely