Format NVMe automatically with 512B block size. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure we're using 512B logical block size with NVMe, image-installation fails if logical block size is 4096B.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we're using 512B logical block size with NVMe, image-installation fails if logical block size is 4096B.
Tried to install on 4096B formatted NVMe (SN850 on Yellow PoE with CM4 2GB Lite) and it failed silently (looked like successful installation, just steady green+red on next boot).
Caveat: I don't have a NVMe-disk without 512B block size support so cannot confirm does format actually error out.
Other option (instead of just plain formatting with -b 512) would be to interrogate NVMe which lbaf formats it has and check if lbads:9 is missing completely.
(pull-request-retry: renamed branch, refined patch & author-data)