Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Three small fixes #17

Closed
wants to merge 3 commits into from
Closed

Three small fixes #17

wants to merge 3 commits into from

Conversation

danmichaelo
Copy link

  • The full namespace should be used since the prefix can vary
  • The extraction of nextRecordPosition was missing .item(0)
  • The readme examples used url, not serverUrl

@natlibfi-arlehiko
Copy link
Contributor

Thanks for this PR @danmichaelo! @natlibfi-jonollil check that this change doesn't break our applications and if it does, then those applications should be fixed (Changing the namespace prefix to namespace URL is a correct way to do it).

@natlibfi-arlehiko
Copy link
Contributor

A new version has been released. The namespace bug is still not fixed but I've created an issue #25 for it.

@natlibfi-jonollil natlibfi-jonollil removed their request for review August 31, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danmichaelo @natlibfi-arlehiko