feat: allow login to non-db contracts #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, each time updateAccount was triggered the VM checked if the selector was connected - i.e. had an access key - to a contract different from SocialDB, and proceed to logout the user if that was the case. This commit removes this constraint, allowing users to connect to both SocialDB and other contracts.
|
this PR solves issue #184 |
|
Don't remove the change, but make it configurable instead. This is desired behavior for default gateways that only use it with a single contract |
|
@evgenykuzyakov yes, that makes sense. I reverted my changed and added a check for a config flag. |
charleslavon
reviewed
May 1, 2024
chore: specify which contract is allowed to be logged-in
|
changed the code based on @charleslavon request, now the |
|
I meant to push to this pr, not merge to dev. I'll push another change shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, each time updateAccount was triggered the VM checked if the selector was connected - i.e. had an access key - to a contract different from SocialDB, and proceed to logout the user if that was the case.
This commit removes this constraint, allowing users to connect to both SocialDB and other contracts.