Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][ADD] account_budget_oca_analytic_tag #58

Open
wants to merge 3 commits into
base: 14.0
Choose a base branch
from
Open

[14.0][ADD] account_budget_oca_analytic_tag #58

wants to merge 3 commits into from

Conversation

cvinh
Copy link
Contributor

@cvinh cvinh commented Oct 31, 2022

Courtesy of @max3903

@cvinh cvinh force-pushed the 14.0-add_account_budget_oca_analytic_tag branch 2 times, most recently from 2745daf to 52ac7ee Compare October 31, 2022 17:59
@max3903 max3903 added this to the 14.0 milestone Oct 31, 2022
@max3903
Copy link
Sponsor Member

max3903 commented Oct 31, 2022

@cvinh We will want to separate in 2 PRs.

@max3903 max3903 self-assigned this Oct 31, 2022
@cvinh cvinh force-pushed the 14.0-add_account_budget_oca_analytic_tag branch from 52ac7ee to 3a99d68 Compare October 31, 2022 18:42
@cvinh cvinh changed the title [14.0][ADD] account_budget_oca_analytic_tag + purchase_budget_oca_validation [14.0][ADD] account_budget_oca_analytic_tag Oct 31, 2022
@cvinh
Copy link
Contributor Author

cvinh commented Oct 31, 2022

@cvinh We will want to separate in 2 PRs.

Done

@cvinh cvinh force-pushed the 14.0-add_account_budget_oca_analytic_tag branch from 3a99d68 to 16e99c0 Compare March 19, 2023 19:21
@cvinh cvinh force-pushed the 14.0-add_account_budget_oca_analytic_tag branch from 16e99c0 to 3176f01 Compare March 20, 2023 18:27
@cvinh cvinh mentioned this pull request Mar 20, 2023
Open
rvalyi
rvalyi requested changes Jun 9, 2023
View reviewed changes
Copy link
Member

@rvalyi rvalyi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two immediate remarks:

  1. usually this kind of logo is not accepted in the OCA https://github.com/OCA/account-budgeting/pull/58/files#diff-8118393e2174e2ba6b031f266e1e4a8b45697baddc3cd591c01398dc1ccf549e
  2. I think some tests would be required. The current coverage is at 40% while the repo coverage is at 75%

@cvinh cvinh force-pushed the 14.0-add_account_budget_oca_analytic_tag branch 8 times, most recently from ba49179 to daf9319 Compare June 9, 2023 08:04
@cvinh cvinh force-pushed the 14.0-add_account_budget_oca_analytic_tag branch from daf9319 to 98a81a7 Compare June 9, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvalyi rvalyi rvalyi requested changes

Assignees

@max3903 max3903

Labels
enhancement needs fixing
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cvinh @max3903 @rvalyi @dreispt