-
-
Notifications
You must be signed in to change notification settings - Fork 454
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move CEventNotifier class to xrCore and slightly refactoring it
This class can be useful in the other places of the engine. After the refactoring the callback is allowed to unsubscribe himself frm ProcessEvent - it won't cause immediate deleting the callback's instance. Callback will be deleted only after ProcessEvent is completed.
- Loading branch information
1 parent
1980ecb
commit 2af9583
Showing
10 changed files
with
182 additions
and
166 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,114 @@ | ||
#pragma once | ||
|
||
#include "xrCommon/xr_smart_pointers.h" | ||
#include "xrCommon/xr_vector.h" | ||
#include "xrCommon/xr_array.h" | ||
#include "xrCore/Threading/Lock.hpp" | ||
#include "xrCore/Threading/ScopeLock.hpp" | ||
|
||
class CEventNotifierCallback | ||
{ | ||
public: | ||
using CID = size_t; | ||
static const CID INVALID_CID = std::numeric_limits<CID>::max(); | ||
|
||
virtual void ProcessEvent() = 0; | ||
virtual ~CEventNotifierCallback(){}; | ||
}; | ||
|
||
template <unsigned int CNT> | ||
class CEventNotifier | ||
{ | ||
private: | ||
class CCallbackStorage | ||
{ | ||
class CCallbackWrapper | ||
{ | ||
public: | ||
xr_unique_ptr<CEventNotifierCallback> callback; | ||
bool destroying = false; | ||
bool executing = false; | ||
|
||
CCallbackWrapper(CEventNotifierCallback* cb) : callback(cb){}; | ||
bool operator==(const CEventNotifierCallback* cb) { return cb == callback.get(); } | ||
void Reset() | ||
{ | ||
callback.reset(nullptr); | ||
destroying = false; | ||
executing = false; | ||
} | ||
}; | ||
xr_vector<CCallbackWrapper> m_callbacks; | ||
Lock m_lock; | ||
|
||
public: | ||
CEventNotifierCallback::CID RegisterCallback(CEventNotifierCallback* cb) | ||
{ | ||
ScopeLock lock(&m_lock); | ||
auto it = std::find(m_callbacks.begin(), m_callbacks.end(), nullptr); | ||
return (it == m_callbacks.end()) ? (m_callbacks.emplace_back(cb), m_callbacks.size() - 1) : | ||
(it->callback.reset(cb), std::distance(m_callbacks.begin(), it)); | ||
} | ||
|
||
bool UnregisterCallback(CEventNotifierCallback::CID cid) | ||
{ | ||
bool result = false; | ||
ScopeLock lock(&m_lock); | ||
if (cid < m_callbacks.size() && m_callbacks[cid].callback != nullptr) | ||
{ | ||
if (!m_callbacks[cid].destroying) | ||
{ | ||
result = true; | ||
m_callbacks[cid].destroying = true; | ||
} | ||
|
||
if (!m_callbacks[cid].executing) | ||
{ | ||
m_callbacks[cid].Reset(); | ||
} | ||
} | ||
return result; | ||
} | ||
|
||
void ExecuteCallbacks() | ||
{ | ||
ScopeLock lock(&m_lock); | ||
for (CEventNotifierCallback::CID i = 0; i < m_callbacks.size(); ++i) | ||
{ | ||
auto& cb = m_callbacks[i]; | ||
if (cb.callback != nullptr && !cb.destroying) | ||
{ | ||
cb.executing = true; | ||
cb.callback->ProcessEvent(); | ||
cb.executing = false; | ||
|
||
if (cb.destroying) | ||
{ | ||
UnregisterCallback(i); | ||
} | ||
} | ||
} | ||
} | ||
}; | ||
|
||
xr_array<CCallbackStorage, CNT> m_callbacks; | ||
|
||
public: | ||
CEventNotifierCallback::CID RegisterCallback(CEventNotifierCallback* cb, unsigned int event_id) | ||
{ | ||
R_ASSERT(event_id < CNT); | ||
return m_callbacks[event_id].RegisterCallback(cb); | ||
} | ||
|
||
bool UnregisterCallback(CEventNotifierCallback::CID cid, unsigned int event_id) | ||
{ | ||
R_ASSERT(event_id < CNT); | ||
return m_callbacks[event_id].UnregisterCallback(cid); | ||
} | ||
|
||
void FireEvent(unsigned int event_id) | ||
{ | ||
R_ASSERT(event_id < CNT); | ||
m_callbacks[event_id].ExecuteCallbacks(); | ||
} | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.