xrGame/ui/UIRankingWnd.cpp: fix a crash when try to update the rankin…

…g tab when the pda is closed
OpenXRay · Sep 15, 2024 · f538f61 · f538f61
1 parent 3d00030
commit f538f61
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/xrGame/ui/UIPdaWnd.cpp b/src/xrGame/ui/UIPdaWnd.cpp
@@ -348,7 +348,7 @@ void CUIPdaWnd::UpdatePda()
 
 void CUIPdaWnd::UpdateRankingWnd()
 {
-    if (pUIRankingWnd)
+    if (pUIRankingWnd && pUIRankingWnd->IsShown())
         pUIRankingWnd->Update();
 }
 

diff --git a/src/xrGame/ui/UIRankingWnd.cpp b/src/xrGame/ui/UIRankingWnd.cpp
@@ -69,7 +69,8 @@ void CUIRankingWnd::Show(bool status)
 
 void CUIRankingWnd::Update()
 {
-    inherited::Update();
+    if (inherited::IsShown())
+        inherited::Update();
     if (Device.dwTimeGlobal - m_previous_time > m_delay)
     {
         m_previous_time = Device.dwTimeGlobal;