Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wunused-variable warnings (#713) #1486

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

AMS21
Copy link
Contributor

@AMS21 AMS21 commented Oct 27, 2023

Mostly resorted to commenting out variables in case they might still be useful to someone someway.

What confused me is the bit in IPureClient::Disconnect(). This almost looks like we're missing some cleanup here.

@AMS21 AMS21 changed the title Fix Wunused-variable warning Fix Wunused-variable warnings Oct 27, 2023
@Xottab-DUTY
Copy link
Member

Uh-oh, this conflicts with #1425. @Masterkatze is working on warnings task, and a CMake refactoring.
So, I'm okay if you both will work on that, but we need to synchronize the work, so that we don't spend time on duplicating changes :)

@Xottab-DUTY Xottab-DUTY changed the title Fix Wunused-variable warnings Fix Wunused-variable warnings (#713) Oct 27, 2023
@AMS21
Copy link
Contributor Author

AMS21 commented Oct 27, 2023

Oh very good point. Thanks for pointing that out :)

@Xottab-DUTY
Copy link
Member

Xottab-DUTY commented Oct 27, 2023

What confused me is the bit in IPureClient::Disconnect(). This almost looks like we're missing some cleanup here.

From what I heard, there's a ton of stack overflows and other bugs.
From what I know, they are actually USED to turn multiplayer servers down, exploited for cheats, etc.

(only on Windows, Linux builds don't support multiplayer at all currently)

@AMS21 AMS21 force-pushed the warnings/unused-variable branch 3 times, most recently from abef089 to 7642874 Compare October 28, 2023 09:50
@AMS21
Copy link
Contributor Author

AMS21 commented Oct 28, 2023

Removed all changes to files inside src/Layers as to not conflict with #1425

@AMS21
Copy link
Contributor Author

AMS21 commented Oct 28, 2023

What confused me is the bit in IPureClient::Disconnect(). This almost looks like we're missing some cleanup here.

From what I heard, there's a ton of stack overflows and other bugs. From what I know, they are actually USED to turn multiplayer servers down, exploited for cheats, etc.

(only on Windows, Linux builds don't support multiplayer at all currently)

Oh no but I don't think fixing these problems is a high priority.

@github-actions github-actions bot removed the Renderer label Oct 28, 2023
@Xottab-DUTY Xottab-DUTY merged commit 8f76f70 into OpenXRay:dev Oct 28, 2023
21 of 22 checks passed
@Xottab-DUTY Xottab-DUTY linked an issue Nov 15, 2023 that may be closed by this pull request
25 tasks
@AMS21 AMS21 deleted the warnings/unused-variable branch November 21, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler warnings elimination
2 participants