-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Wunused-variable
warnings (#713)
#1486
Conversation
04950e2
to
f93e3f3
Compare
Uh-oh, this conflicts with #1425. @Masterkatze is working on warnings task, and a CMake refactoring. |
Wunused-variable
warningsWunused-variable
warnings (#713)
Oh very good point. Thanks for pointing that out :) |
From what I heard, there's a ton of stack overflows and other bugs. (only on Windows, Linux builds don't support multiplayer at all currently) |
abef089
to
7642874
Compare
Removed all changes to files inside |
Oh no but I don't think fixing these problems is a high priority. |
7642874
to
e3fe88b
Compare
Mostly resorted to commenting out variables in case they might still be useful to someone someway.
What confused me is the bit in
IPureClient::Disconnect()
. This almost looks like we're missing some cleanup here.