-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Self curse implementation and changes to curses from config #5074
Conversation
Would you mind using "no" (or similar) instead of "dont" in variable names? Sorry for the pedantry. :) |
…OfBuilding into curseAurasAndSelfFix
Less curse effect against players on gem doesn't seem to work but does for config? Most likey doesn't
Unsure (currently does)
Should (currently doesn't)
Blade Vortex and Winter Orb Probably works. Players cursed shouldn't effect minion skills Was the fixes meant to be #5069 or it fixes both? |
|
It was initially meant to fix #5069 but ever since @Regisle mentioned he'd like to implement some changes to curses this pr blew up in scope as i read the code more and had more and more ideas. I'll likely focus on breaking this pr up into 2 separate ones:
|
Switching back to draft in the mean time as i move things around. |
7d6333b
to
321a702
Compare
…ill duration." This reverts commit 4e7d432.
Hex proof is currently implemented as 100% reduced effect of curses. This will still apply to marks. A new mod probably needs implementing hexEffectOnSelf as 100% less or a mod flag such as I think if you are an occulist and use can apply to hexproof enimies you might be able to override vidiri's veil. |
Support for "Your Elemental Resistances cannot be lowered by Curses" mod.
I've added support for the |
…OfBuilding into curseAurasAndSelfFix
78dc8c6
to
04fe40a
Compare
|
Fixes #5056 , #5069.
Description of the problem being solved:
This pr improves ui and curse mechanics. Implements self curse handling and fixes related issues.
Currently work in progress.
TODO: