Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self curse implementation and changes to curses from config #5074

Closed
wants to merge 107 commits into from

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Sep 13, 2022

Fixes #5056 , #5069.

Description of the problem being solved:

This pr improves ui and curse mechanics. Implements self curse handling and fixes related issues.

Currently work in progress.
TODO:

  • Drop down for curses in the config. ✔️
  • Handling for increased curse effect from curses. ✔️
  • Handling multiple sources of the same curse with different strengths ✔️
  • Make config curses take priority. ✔️
  • Implement handling for reflected curses. ✔️
  • Implement self duration modifiers from temp chains and other sources ✔️
  • Refactor the drop down list selection into a new control ?

@Nightblade
Copy link
Contributor

Would you mind using "no" (or similar) instead of "dont" in variable names? Sorry for the pedantry. :)

@QuickStick123 QuickStick123 added the enhancement New feature, calculation, or mod label Sep 19, 2022
@Paliak Paliak marked this pull request as ready for review September 21, 2022 18:13
@QuickStick123
Copy link
Contributor

QuickStick123 commented Sep 22, 2022

Less curse effect against players on gem doesn't seem to work but does for config?
Maybe add self curses to the Aura and Buff Skills config section so you can see them apply effects to the player.
image
Divine blessing aura doesn't seem to work temp chains reduced buff effect. There are some skills that it probably shouldn't effect
image
image

Most likey doesn't

  • Galvanic field.
  • Conc Path
  • Toxic Rain
  • Pretty much all the other skill duration skills the create something with a duration e.g. creeping frost, vortex, etc.

Unsure (currently does)

  • Herald of Thunder
  • Convocation
  • Herald of purity

Should (currently doesn't)

  • Corrupting fever primary buff.

Blade Vortex and Winter Orb Probably works.
Minion duration shouldn't be affected but (currently are) this is more of general issue with minion duration belonging to the player not the minion.
Probably should affect our ailment duration
image

Players cursed shouldn't effect minion skills
image
These could probably use spaces
image
Hexproof is currently implemented as 100% reduced curse effect on self. This might stop reflected marks from applying to the player. https://www.poewiki.net/wiki/Hexproof
image
Probably add support for this as well. (Enemy Hits inflict Temporal Chains on you)
image
Breakdown looks a little mangled
image
It also doesn't hide when it does nothing e.g.
image

Was the fixes meant to be #5069 or it fixes both?

@QuickStick123
Copy link
Contributor

QuickStick123 commented Sep 22, 2022

image
Phantasmal haste might have slightly different functionallity to temp chains and might stack additivly instead of multiplicibly. (faster bleed is inc according to PoB testing might be a good idea.) But is implemeneted the same way.
There is also shapers presence that seems to stack additivly https://www.poewiki.net/wiki/Shaper%27s_Presence but is currently not supported.
image

@Paliak
Copy link
Contributor Author

Paliak commented Sep 22, 2022

Was the fixes meant to be #5069 or it fixes both?

It was initially meant to fix #5069 but ever since @Regisle mentioned he'd like to implement some changes to curses this pr blew up in scope as i read the code more and had more and more ideas. I'll likely focus on breaking this pr up into 2 separate ones:

@Paliak Paliak marked this pull request as draft September 22, 2022 14:24
@Paliak
Copy link
Contributor Author

Paliak commented Sep 22, 2022

Switching back to draft in the mean time as i move things around.

@QuickStick123
Copy link
Contributor

Hex proof is currently implemented as 100% reduced effect of curses. This will still apply to marks. A new mod probably needs implementing hexEffectOnSelf as 100% less or a mod flag such as I think if you are an occulist and use can apply to hexproof enimies you might be able to override vidiri's veil.

@Paliak
Copy link
Contributor Author

Paliak commented Apr 7, 2023

I've added support for the Your Elemental Resistances cannot be lowered by Curses mod here instead of a new pr due to this pr introducing better on player curse handling.

@Paliak Paliak marked this pull request as draft August 31, 2023 20:14
@Paliak Paliak marked this pull request as ready for review September 1, 2023 09:59
@Paliak Paliak marked this pull request as draft January 2, 2024 04:38
@Paliak
Copy link
Contributor Author

Paliak commented Jan 2, 2024

base_tertiary_skill_effect_duration has been added since this pr was written and is not supported. Likely good chunks of this pr would need to be updated to work correctly.

@Paliak
Copy link
Contributor Author

Paliak commented Aug 17, 2024

Ui code superseded by #8203. The self curse parts need a rework and it seems @Regisle is working on that so this should be good to close.

@Paliak Paliak closed this Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reservation mastery calculation bug
5 participants