Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tincture effect fixes #8151

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

Regisle
Copy link
Member

@Regisle Regisle commented Aug 11, 2024

Fixes #8090 and #8039 .

Scales tincture items like jewellery with catalysts (this can easily be modified to also scale other items by modifiers effect like for heist bases or enchants)

Currently need to fix exporter (or how the mods are tagged) but also I am unsure if this is the best way to handle these, this seems like its not the optimal solution

@Paliak Paliak added the bug: calculation Numerical differences label Aug 15, 2024
@Regisle
Copy link
Member Author

Regisle commented Aug 30, 2024

Taking this out of draft as I have gotten rid of all the issues I found during testing, only remaining issue is the exporting of tincture items strips the "tincture" tag from the implicits as its not a real tag, unsure the best way to handle it (forcing the tag if the base type is a tincture seems the best?)

I ended up removing the range scalar function as the call to it was becoming so long that all benefits of using a function other than code dedupe was gone, and as for code dedupe, the 3 places its needed all have slightly different requirements and so needing the cover all those adds a bunch of extra boilerplate into the function
see b4225b5 for the function and its calls before it was removed, if we want to keep it I can easily revert to that commit

@Regisle Regisle marked this pull request as ready for review August 30, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increased effect affixes on Tinctures are local and multiplicative with Tree/Ascendancy increases
2 participants