Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Reset 'Enemy Damage Type' after 'Boss Skill Preset' #8284

Closed
wants to merge 1 commit into from

Conversation

n1tr0xs
Copy link
Contributor

@n1tr0xs n1tr0xs commented Sep 2, 2024

Fixes #7870 .

Description of the problem being solved:

When you set the 'Boss Skill Preset' back to 'None' to see the normal EHP/Max Hit values the 'Enemy Damage Type' stays the same as whatever the Boss Skill was.

Steps taken to verify a working solution:

  • Select any boss skill preset.
  • Select preset to None.
  • Chech damage type.
  • Must be "Average".

Before screenshot:

image

After screenshot:

image

@ConnorThelin
Copy link
Contributor

This change creates a functionality loss where the user is not able to select anything other than Average for Enemy Damage Type when Boss Skill Preset is set to None.

I have not used this functionality much so do not know how important it is, but worth noting.

@Regisle
Copy link
Member

Regisle commented Sep 8, 2024

Yeah this wasnt done before like this due to the apply function being called every time and so we generally only want to set placeholders etc there, and ideally we would also want to remember the last value saved, this can be done by overwriting the control itself but that was too messy, I wish you luck in solving the issue

@n1tr0xs n1tr0xs closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reset 'Enemy Damage Type' after 'Boss Skill Preset' is used in configs
3 participants