Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add debugging section #6857

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

docs: add debugging section #6857

wants to merge 3 commits into from

Conversation

czuma
Copy link

@czuma czuma commented Sep 3, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • [ x ] I have made corresponding changes to the Qwik docs
  • Added new tests to cover the fix / functionality

@czuma czuma requested a review from a team as a code owner September 3, 2024 15:50
Copy link

changeset-bot bot commented Sep 3, 2024

⚠️ No Changeset found

Latest commit: 2b06cac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gioboa gioboa linked an issue Sep 6, 2024 that may be closed by this pull request
@gioboa gioboa changed the title add debugging section to docs issue #6836 docs: add debugging section to docs issue #6836 Sep 6, 2024
@gioboa gioboa changed the title docs: add debugging section to docs issue #6836 docs: add debugging section#6836 Sep 6, 2024
@gioboa gioboa changed the title docs: add debugging section#6836 docs: add debugging section Sep 6, 2024
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me 👏 thanks @czuma

@gioboa gioboa requested a review from maiieul September 6, 2024 07:06
Copy link
Contributor

github-actions bot commented Sep 6, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 6ffe057

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but isn't it easier to use npx vite-bundle-visualizer? Could even be a default script in the starter

@czuma
Copy link
Author

czuma commented Sep 11, 2024

Nice, but isn't it easier to use npx vite-bundle-visualizer? Could even be a default script in the starter

THAT'S GREAT! i tested and works amazing. Maybe we can split this in 2 parts, 1 is document this command instead of my PR, and 2nd part is to add to starter like you say. Let me work on that.

@wmertens
Copy link
Member

@czuma I think you can do both things in this PR. Looking forward to our new debugging sections in the docs! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[📖] How to debug Big js chunks on build
3 participants