Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert pulling zlib from custom fork #660

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Revert pulling zlib from custom fork #660

wants to merge 3 commits into from

Conversation

GeckoEidechse
Copy link
Member

Reverts #650 which was done due to builds failing due to madler/zlib@2e3d86c

@GeckoEidechse
Copy link
Member Author

GeckoEidechse commented Feb 4, 2024 •
edited
Loading

If CI passes, this should be good to merge

EDIT: RIP

@GeckoEidechse
Copy link
Member Author

@ASpoonPlaysGames I assumed it would just pull the newest zlib version but evidently that's not the case? Or is the upstream fix not working for us?

@ASpoonPlaysGames
Copy link
Contributor

It fetches the master branch, the fix is only on develop right now

@GeckoEidechse GeckoEidechse marked this pull request as draft February 4, 2024 16:23
@GeckoEidechse
Copy link
Member Author

Yeah so develop branch works, don't think we should use that though so best to wait until merged into master ig ^^

@Alystrasz
Copy link
Contributor

The fix for the issue still wasn't ported to master as of today.
Commit: madler/zlib@f1f503d (Jan. 29th)
Last release: https://github.com/madler/zlib/releases/tag/v1.3.1 (Jan. 22nd)

@GeckoEidechse
Copy link
Member Author

:dread:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GeckoEidechse @ASpoonPlaysGames @Alystrasz