Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore missing faction dialogue for Titan Meter buildup #876

Merged
merged 7 commits into from
Oct 2, 2024

Conversation

Zanieon
Copy link
Contributor

@Zanieon Zanieon commented Sep 10, 2024

Currently we have a missing characteristic from the Titan Meter that the faction leader will speak about the pilot's titan being almost ready when it reaches around 75%, and then immediately telling their Titan is ready soon as it hits 100%, this is my attempt to bring that behavior back.

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 10, 2024
@Zanieon Zanieon changed the title Fix faction dialogue for Titan Meter buildup Restore missing faction dialogue for Titan Meter buildup Sep 11, 2024
Copy link
Contributor

@JMM889901 JMM889901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, didn't test though

@NachosChipeados
Copy link
Contributor

Can confirm that this does add the missing voicelines. Just one small issue though: mp_titanSoon ocasionally doesn't play, not entirely sure why that happens. It makes sense for mp_titanReady since Respawn made it have a 50/50 chance of playing, but i don't see anything similar for mp_titanSoon.

Before:
https://github.com/user-attachments/assets/84ba12d9-3ba6-44a5-9bb0-8b0a244c2838

After:
https://github.com/user-attachments/assets/e23028a4-b187-44b4-8937-dd03644ec462

@NachosChipeados
Copy link
Contributor

NachosChipeados commented Oct 1, 2024

Actually, i guess im not sure if i would call that an issue. That makes it match mp_titanReady's behaviour and it also isn't gamebraking at all. I think its just odd that it randomly doesn't play for seemingly no reason

@GeckoEidechse GeckoEidechse removed the needs testing Changes from the PR still need to be tested label Oct 1, 2024
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked over it with @Zanieon in vc together and the changes implemented appear to be correct.

Not a big fan of the way the state tracking is done but it matches existing logic so it's fine ig.

@GeckoEidechse GeckoEidechse merged commit 75e95ef into R2Northstar:main Oct 2, 2024
3 checks passed
@Zanieon Zanieon deleted the earnmeter_patch branch October 2, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs code review Changes from PR still need to be reviewed in code vanilla parity
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants