Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align the the text for the "Join" button #877

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Align the the text for the "Join" button #877

wants to merge 4 commits into from

Conversation

eve-v0
Copy link
Contributor

@eve-v0 eve-v0 commented Sep 10, 2024 •
edited
Loading

Update server_browser.menu
Makes text in "Join" button allign to middle/north which looks better
image

Splitting into separate prs as requested by gecko
Link to old PR #874

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 10, 2024
@GeckoEidechse GeckoEidechse changed the title Update server_browser.menu - Align the the text for the "Join" button Align the the text for the "Join" button Sep 10, 2024
Alystrasz
Alystrasz approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As reviewed in #874, button text is now centered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alystrasz Alystrasz Alystrasz approved these changes

Assignees
No one assigned
Labels
needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested
Projects
Northstar Roadmap
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eve-v0 @Alystrasz