Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mode selection menu locking all modes #880

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Fix mode selection menu locking all modes #880

merged 1 commit into from
Sep 11, 2024

Conversation

Zanieon
Copy link
Contributor

@Zanieon Zanieon commented Sep 11, 2024

Issue that came with #624 that have a very smol oversight in the check block.

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 11, 2024
@Zanieon Zanieon linked an issue Sep 11, 2024 that may be closed by this pull request
All gamemodes in private match are marked as locked #878
Closed
GeckoEidechse
GeckoEidechse approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing. All gamemodes (except FD) are unlocked again as they were before.

As for code review, this simply inverts a check so not much to review here ^^

@GeckoEidechse GeckoEidechse removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 11, 2024
@GeckoEidechse GeckoEidechse merged commit 6437c5e into R2Northstar:main Sep 11, 2024
5 checks passed
@Zanieon Zanieon deleted the privatelockfix branch September 11, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All gamemodes in private match are marked as locked
2 participants
@Zanieon @GeckoEidechse