Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix when player zoom OffhandWeapon and switch back to main weapon will not call the OnWeaponZoom callback #892

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

LightBlueCube
Copy link
Contributor

2024-10-12.12-37-16.mp4

Before ↑

2024-10-12.12-31-01.mp4

After ↑

Sorry for my bad English, lmk if u need more information

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Oct 12, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a modified vanilla file, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@Zanieon
Copy link
Contributor

Zanieon commented Oct 12, 2024

Ah yeah the old Splitter Glitch, this will probably not gonna get merged since we all agreed in keep the weapon bugs in the game as they are in vanilla.

@LightBlueCube
Copy link
Contributor Author

Ah yeah the old Splitter Glitch, this will probably not gonna get merged since we all agreed in keep the weapon bugs in the game as they are in vanilla.

This bug affect too much, its very easy to use it, and u can see how many of damage i made in first video

@Zanieon
Copy link
Contributor

Zanieon commented Oct 12, 2024

We all know about it for years, we know how stupid this messes up with Ion's DPS, but so does other bugs that also affects the DPS and functionality of other weapons. I'd be down to fix this issue myself and PR it last year, but the agreement is to not change weapons problems for now.

@LightBlueCube
Copy link
Contributor Author

We all know about it for years, we know how stupid this messes up with Ion's DPS, but so does other bugs that also affects the DPS and functionality of other weapons. I'd be down to fix this issue myself and PR it last year, but the agreement is to not change weapons problems for now.

will okay, I respect you choice, thx for the reply❤️

@GeckoEidechse
Copy link
Member

I'd be down to fix this issue myself and PR it last year, but the agreement is to not change weapons problems for now.

Maybe we should consider some riff or something "disable" the bugs. So have a bunch of fixes but have the fix disabled by default with an option to enable the fix.

On one side it would be nice to have some of the bugs fixed, on the other side, a bug could also be considered an feature of the game. For example air strafing was originally a bug yet it's a quintessential feature of movement shooters.

Basically this a question of preservation vs correctness.

@ASpoonPlaysGames
Copy link
Contributor

I'd be fine with locking it behind a convar/playlistvar. Could even be enabled by default if you want. The splitter bug has a large impact on gameplay so I think doing nothing is silly, but we should also offer an "untainted" vanilla experience so it should be toggleable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants