Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single article page #33

Closed
wants to merge 45 commits into from
Closed

Single article page #33

wants to merge 45 commits into from

Conversation

eliftabak
Copy link
Collaborator

No description provided.

@louisrli
Copy link
Contributor

louisrli commented Aug 8, 2020

@bahaadabbagh please review this within 24 hours of it being sent out

<Row>
<Col xs={6} md={6} lg={8}>
<h3>{blog.title}</h3>
<span>{blog.body.substring(0, 200)}</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depending on where the blog is coming from you probably don't want to do it this way because random letters will be cut off. in wordpress there is an 'excerpt' on the object that you can use

i see its coming from the translation files, actually the right way to do this is to add an "excerpt" field as well so that each excerpt is customized. cutting off in the middle of the word at a random character is a bad user experience

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we didn't start using WordPress yet.... but definitely I will check it out

src/components/blog-cards/blog.json Outdated Show resolved Hide resolved
@bahaadabbagh bahaadabbagh self-requested a review August 8, 2020 17:49
@bahaadabbagh bahaadabbagh linked an issue Aug 8, 2020 that may be closed by this pull request
src/components/blog-cards/blog.json Outdated Show resolved Hide resolved
@@ -13,7 +13,7 @@

/* bootstrap class */
.navbar-light .navbar-nav .nav-link {
color: #6c567b;
color: #6c567b !important;
font-style: normal;
font-weight: normal;
font-size: 14px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

px to rem

@@ -53,18 +53,18 @@
width: 6em;
height: 2.3em;
margin: 0.3em;
border-radius: 40px;
border-radius: 40px !important;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

px to rem

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still px

<span>{blog.body.substring(0, 200)}</span>
</Col>
<Col xs={6} md={4} lg={3}>
<Image src="holder.js/171x180" roundedCircle />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't get the name of the src

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a place holder from bootstrap i changed it

src/components/blog-cards/BlogCard.jsx Show resolved Hide resolved
Copy link
Collaborator

@bahaadabbagh bahaadabbagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry if I'm giving my review before you ask for it but I hope it helps

"title": "My Intersectional Activism as A Black African Muslim Woman",
"body": "My identities as being a Black Muslim woman who is also African come in one. I experience discrimination in many unique ways: my skin colour, my gender, my religion and being African. Often, the notion of have these identities tend to equate to me being a ‘thug’ (black), a ‘terrorist’ (Muslim), ‘poor’ (African) and oppressed (woman). But I’m here to say that this is not the case and I would not have it any other way. This is why I always emphasise on the importance of intersectional activism.Naturally, having these intersections make me an activist. I fight for Black people and for women, for Muslims and for Africans. I guess you could say I’m quite strong. Pay attention to those who are being excluded. It is vital to pay attention and listen to those whose voices often go unheard or are dismissed. I am very skilled in this because when I am fighting for one part of my identity – often the other 3 go dismissed. Perfect example: the Black Lives Matter movement. Certain parts of the Muslim community do not acknowledge the Black Lives Matter movement because it’s a ‘race’ issue, not a religion issue. As if black Muslims are not being shot by police too, such as Yassin Mohammed and Amadou Diallo. Some bring up ‘what about Palestine?’ yet fail to acknowledge the suffering of Afro-Palestinians. Others are excluding disabled black people from the Black Lives Matter movement as we are less likely to hear their stories. My identities are just as important – they come as one. My Blackness does not exclude my ‘Muslimness’ or my ‘Africaness’ or my ‘womanhood’. They matter just as much as each other. A perfect example of this would be the unfortunate killing of Shukri Abdi, which has prompted conversations on social media when it comes to #BlackLivesMatter. Shukri was an immigrant from Somalia who was murdered in Manchester, England and she had the same identities as me – Black, Muslim, African and a girl. Shukri’s death shook the Internet as it really exposed the lack of intersectional activism that some people have. Some ignored her death because of her Muslim identity or claimed that she’s Somali and not Black. Either way, I am not part of the Somali community so I cannot fully comment on her identity. Obviously, not all Black people in the UK are excluding her death but just a select few. I just wanted to re-emphasise the importance of why ALL Black Lives Matter! #JusticeforShukriAbdi Mental health matters too. Another intersection is mental health and ability. Yassin Mohammed was murdered by police in the US. He was a Sudanese immigrant with mental health issues. Another death that was swept under the rug until it picked up on Twitter. Why is that? Certain demographics fail to acknowledge intersections such as mental health and his immigrant identity, similar to Shukri’s. Perhaps he was not ‘Black’ enough because he had Sudanese descent or because he was a Muslim? Yassin’s and Shukri’s murders are just as important to the Black Lives Matter movement. Regardless of their Muslim or immigrant identity, we must say their names too. Their lives mattered. #BlackLivesMatter is global. Following the murder of George Floyd, protests literally sparked across the globe with many black women leading at the forefront. Two 18 year old women organised the London protests. Assa Traoré in France lead the #BlackLivesMatter movement for her brother Adama Traoré. He was murdered and many other lives taken from state sanctioned violence. These international protests are not significantly only for George Floyd or for Breonna Taylor or for Tony McDade, but for the countless black people murdered daily due to this state sanctioned violence. It highlights how anti-blackness is perpetuated all over the globe. It also puts into perspective how a new global order could potentially occur – how things can change and how we can be the change. “I am not free while any woman is unfree, even when her shackles are very different from my own.” – Audre Lorde <br> Finally, I just wanted to leave this here and just want to remind people to always take an intersectional approach to activism. Because ALL Black Lives Matter around the world.",
"author": "Bashirat Oladele",
"imgUrl": "/images/blackmuslim.png"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

balckMuslim

src/components/blog-cards/blog.json Show resolved Hide resolved
@@ -53,18 +53,18 @@
width: 6em;
height: 2.3em;
margin: 0.3em;
border-radius: 40px;
border-radius: 40px !important;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still px

src/components/blog-cards/BlogCard.css Show resolved Hide resolved
@eliftabak eliftabak closed this Aug 14, 2020
@eliftabak eliftabak deleted the single-article-page branch August 14, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

singleArticlePage
4 participants