Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated method and add Ethereum (ETH) to non-ISO currencies #1069

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

douglas-franca
Copy link

@douglas-franca douglas-franca commented Jan 23, 2024

This pull request include one change:

  1. Add Ethereum (ETH) to non-ISO currencies: Ethereum has been added to the list of non-ISO currencies, allowing the Money library to handle transactions in Ethereum.

@semmons99
Copy link
Member

please rebase and I will merge

@tagliala
Copy link
Contributor

020c091 should not be needed anymore

"symbol": "Ξ",
"alternate_symbols": [],
"subunit": "Wei",
"subunit_to_unit": 100000000,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ETH to WEI is 1000000000000000000

Suggested change
"subunit_to_unit": 100000000,
"subunit_to_unit": 1000000000000000000,

@semmons99
Copy link
Member

still need a rebase before we can consider merging.

@douglas-franca douglas-franca force-pushed the douglas/add-eth-currency branch 2 times, most recently from 6a63723 to 82a6cc2 Compare March 18, 2024 22:32
semmons99
semmons99 previously approved these changes Apr 15, 2024
@semmons99
Copy link
Member

failing tests 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants