CI: make unzip target depend on download target #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th have SkipUnchangedFiles, in theory it can never be ran twice.
|
Looks like this is still failing due to the zip file not existing. |
|
Thankyou for all the hard work debugging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix CI randomly failing due to "because the file does not exist or is inaccessible" when trying to unzip the deps from
LLamaBinaries.Microsoft mentions the following for the target build order:
In general, you shouldn't depend on the declaration order to specify what tasks run before other tasks.This PR splits up the download & unzip targets and makes the unzip target depend on the download target, so that they can never be executed in the wrong order, and adds download retries so that the build does not fail if there is a temporary issue when downloading the file.