2024-07-30 Node-RED - master branch - PR 1 of 2 #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harmonises list of add-on nodes across old-menu and master branches. I've tried to stay away from SensorsIot#755. This includes removal of `node-red-node-rbe` which has been replaced by the built-in Filter node. See: - [Release notes](https://nodered.org/blog/2021/07/20/version-2-0-released#renamed-rbe-node-to-filter-node) Migrate from `node-red-contrib-themes/midnight-red` (deprecated) to `@node-red-contrib-themes/theme-collection` which supports many more themes. See: - [Node-RED themes list](https://github.com/node-red-contrib-themes/theme-collection#theme-list) Modify Dockerfile template: 1. No need to declare `EXTRA_PACKAGES` as an environment variable. It isn't needed in the container. The `ARG` reference is sufficient. 2. Remove redundant `apk update` command. The `--no-cache` flag on the `apk add` handles both package-list updates and their removal. It makes for a slightly smaller container. I discovered (and tested) this behaviour when posting a reply to: - [node-red-docker issue 338](node-red/node-red-docker#338). Signed-off-by: Phill Kelley <[email protected]>
Slyke
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Harmonises list of add-on nodes across old-menu and master branches. I've tried to stay away from #755. This includes removal of
node-red-node-rbewhich has been replaced by the built-in Filter node. See:Migrate from
node-red-contrib-themes/midnight-red(deprecated) to@node-red-contrib-themes/theme-collectionwhich supports many more themes. See:Modify Dockerfile template:
No need to declare
EXTRA_PACKAGESas an environment variable. It isn't needed in the container. TheARGreference is sufficient.Remove redundant
apk updatecommand. The--no-cacheflag on theapk addhandles both package-list updates and their removal. It makes for a slightly smaller container.I discovered (and tested) this behaviour when posting a reply to: