Merge pull request #52 from dave3d/MakeTestsPythonic

Make the tests more pythonic
SimpleITK · Oct 17, 2023 · c1609e7 · c1609e7
2 parents 20ac538 + 80311c3
commit c1609e7
Showing 1 changed file with 14 additions and 19 deletions.
diff --git a/tests/test_comment_spell_check.py b/tests/test_comment_spell_check.py
@@ -5,19 +5,19 @@
 class TestCommentSpellCheck(unittest.TestCase):
     @classmethod
     def setUpClass(self):
-        print("\nSetting up comment_spell_check tests")
+        """Setting up comment_spell_check tests"""
 
     @classmethod
     def tearDownClass(cls):
-        print("\nTearing down comment_spell_check tests")
+        """Tearing down comment_spell_check tests"""
 
     def test_basic(self):
-        print("\nCommand_spell_check: Basic Test")
+        """Basic test"""
         runresult = subprocess.run(
             [
                 "python",
                 "comment_spell_check.py",
-                "--verbose",
+                "--miss",
                 "--dict",
                 "tests/dict.txt",
                 "--prefix",
@@ -26,18 +26,15 @@ def test_basic(self):
             ],
             stdout=subprocess.PIPE,
         )
-        if runresult.returncode:
-            self.fail("\nBasic Test: FAIL")
-            output_string = str(runresult.stdout)
-            print("\nTest output:", output_string)
+        self.assertEqual(runresult.returncode, 0, runresult.stdout)
 
     def test_codebase(self):
-        print("\nComment_spell_check: Code Base Test")
+        """Code base test"""
         runresult = subprocess.run(
             [
                 "python",
                 "comment_spell_check.py",
-                "--verbose",
+                "--miss",
                 "--prefix",
                 "myprefix",
                 "--suffix",
@@ -48,13 +45,10 @@ def test_codebase(self):
             ],
             stdout=subprocess.PIPE,
         )
-        if runresult.returncode:
-            self.fail("\nCode Base Test: FAIL")
-            output_string = str(runresult.stdout)
-            print("\nTest output:", output_string)
+        self.assertEqual(runresult.returncode, 0, runresult.stdout)
 
     def test_version(self):
-        print("\nComment_spell_check: Version Test")
+        """Version test"""
         runresult = subprocess.run(
             [
                 "python",
@@ -63,8 +57,9 @@ def test_version(self):
             ],
             stdout=subprocess.PIPE,
         )
+        self.assertEqual(runresult.returncode, 0)
+
         version_string = str(runresult.stdout)
-        if runresult.returncode:
-            self.fail("Version Test: FAIL")
-        if "unknown" in version_string:
-            self.fail("Version Test: version string contains 'unknown'")
+        self.assertNotEqual(
+            version_string, "unknown", "version string contains 'unknown'"
+        )