#noissue when the notifications message processing takes long time (few seconds up to 1 minute) PONG responses can be delayed as the socket is blocked, apply workaround in the TooTallNate client to address this issue #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slc-softwareag
requested review from
scmi-c8y,
vartikarai04,
rohitjoshi-c8y,
abor-c8y,
gapa-c8y and
tjegorow-c8y
abor-c8y
previously approved these changes
Sep 25, 2024
...n/java/c8y/example/notification/client/websocket/tootallnate/TooTallNateWebSocketClient.java
Outdated
Show resolved
Hide resolved
gapa-c8y
previously approved these changes
Sep 26, 2024
slc-softwareag
dismissed stale reviews from gapa-c8y and abor-c8y
via
2542c0c
slc-softwareag
force-pushed
the
feature/noissue/apply_tootallnate_workaround_in_notifications_example
branch
3 times, most recently
from
1d55373
to
5f68b90
Compare
scmi-c8y
reviewed
Sep 30, 2024
...n/java/c8y/example/notification/client/websocket/tootallnate/TooTallNateWebSocketClient.java
Outdated
Show resolved
Hide resolved
...n/java/c8y/example/notification/client/websocket/tootallnate/TooTallNateWebSocketClient.java
Outdated
Show resolved
Hide resolved
slc-softwareag
force-pushed
the
feature/noissue/apply_tootallnate_workaround_in_notifications_example
branch
from
5f68b90
to
6b1928d
Compare
scmi-c8y
previously approved these changes
Oct 2, 2024
…ew seconds up to 1 minute) PONG responses can be delayed as the socket is blocked, apply workaround in the TooTallNate client to address this issue
slc-softwareag
force-pushed
the
feature/noissue/apply_tootallnate_workaround_in_notifications_example
branch
from
6b1928d
to
bf33363
Compare
rohitjoshi-c8y
approved these changes
Oct 3, 2024
scmi-c8y
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.