Merge pull request #32 from SolarEdgeTech/yanay-fix-issue-31-app-logg…

…ing-conf Initialize logging before Pyctuator
SolarEdgeTech · Sep 2, 2020 · 69b30f7 · 69b30f7
2 parents 1d71706 + b3ef885
commit 69b30f7
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/examples/Advanced/advanced_example_app.py b/examples/Advanced/advanced_example_app.py
@@ -67,7 +67,6 @@ def recursive_get(child_conf: Dict, key_parts: List[str]) -> Any:
 # A FastAPI application is initialized providing some test API
 # ----------------------------------------------------------------------------------------------------------------------
 
-logging.basicConfig(level=logging.INFO)
 logger = logging.getLogger("ExampleApp")
 
 # Initialize a connection to the DB which the app is using

diff --git a/examples/FastAPI/fastapi_example_app.py b/examples/FastAPI/fastapi_example_app.py
@@ -8,7 +8,6 @@
 
 from pyctuator.pyctuator import Pyctuator
 
-logging.basicConfig(level=logging.INFO)
 my_logger = logging.getLogger("example")
 
 app = FastAPI(

diff --git a/examples/Flask/flask_example_app.py b/examples/Flask/flask_example_app.py
@@ -6,8 +6,6 @@
 
 from pyctuator.pyctuator import Pyctuator
 
-logging.basicConfig(level=logging.INFO)
-
 # Keep the console clear - configure werkzeug (flask's WSGI web app) not to log the detail of every incoming request
 logging.getLogger("werkzeug").setLevel(logging.WARNING)
 

diff --git a/examples/aiohttp/aiohttp_example_app.py b/examples/aiohttp/aiohttp_example_app.py
@@ -6,7 +6,6 @@
 
 from pyctuator.pyctuator import Pyctuator
 
-logging.basicConfig(level=logging.INFO)
 my_logger = logging.getLogger("example")
 app = web.Application()
 routes = web.RouteTableDef()

diff --git a/pyctuator/pyctuator.py b/pyctuator/pyctuator.py
@@ -89,6 +89,11 @@ def __init__(
         self.boot_admin_registration_handler: Optional[BootAdminRegistrationHandler] = None
 
         root_logger = logging.getLogger()
+        # If application did not initiate logging module, add default handler to root logger
+        # logging.info implicitly calls logging.basicConfig(), see logging.basicConfig in Python's documentation.
+        if not root_logger.hasHandlers():
+            logging.info("Logging not configured, using logging.basicConfig()")
+
         root_logger.addHandler(self.pyctuator_impl.logfile.log_messages)
 
         # Find and initialize an integration layer between the web-framework adn pyctuator