Prevent duplicate parts/names in URLs #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please bear with me if I get this wrong, but as far as my understanding of this extension goes, there are different plugins to show blog posts for a certain author, tag, category and year (archive).
This means, that each plugin is supposed to go on a separate page. This is exactly what the automatic setup does.
So, because we are already on a page named "Archive", "Category", "Tag" or "Author", the route enhancer should not add this piece of information again, as this gives us URLs like
https://example.domian/blog/tag/tag/exampletag or
https://example.domian/blog/archive/archive/2020/may
At least that's what happens on the website I'm currently developing.
It makes sense for extensions like news, where there's a single plugin on a single page that fits all.
If my logic so far is correct, and I'm not missing some use-cases, this pull request removes the redundant URL parts from the route enhancer configuration.