Fixes to wiichuck support and upstream compilation checks. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARDUINOJSON_ENABLE_COMMENTS must be set to 1 before including the library. The same value of ARDUINOJSON_ENABLE_COMMENTS must be set in each compilation unit.
Added additional eye functions (close, wide), to replace boop and blink functions on the Wiichuck button functions for better eye puppetry. Other minor style and debugging changes.
Additional eye type for eagles and other birds of prey. Eyelids are *inverted*, eagles blink up as their top eyelid is larger than the bottom one!
Improved configuration documentation of eagle eyes. Minor updates to debugging output.
TonyLHansen
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made fixes to address compilation issues that are preventing the upstream pull request (adafruit#915) from passing compilation checks (compilation fails with file.cpp:288: undefined reference to `user_setup(ArduinoJson6170_91::StaticJsonDocument<2048u>&)'.
Fixed issues with the eyesWide() function that was causing only the left eye to widen when called (and only the right eye to widen on a nose boop).
Minor typographical changes and changes to style to match source code. Improvements made to debugging output.