Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Abel Soares Siqueira <[email protected]>
  • Loading branch information
suvayu and abelsiqueira authored Aug 9, 2024
1 parent 3e91df5 commit 06d82e3
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/pipeline.jl
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ function create_tbl(
tmp::Bool = false,
show::Bool = false,
)
if (check_file(alt_source) && length(name) == 0)
if check_file(alt_source) && length(name) == 0
name = get_tbl_name(alt_source, tmp)
end

Expand Down Expand Up @@ -246,7 +246,7 @@ function set_tbl_col(
# columns? If such a feature is required, we can use
# cols::Dict{Symbol, Vector{Any}}, and get the cols and vals
# as: keys(cols), and values(cols)
if (check_file(source) && length(name) == 0)
if check_file(source) && length(name) == 0
name = get_tbl_name(source, tmp)

Check warning on line 250 in src/pipeline.jl

View check run for this annotation

Codecov / codecov/patch

src/pipeline.jl#L250

Added line #L250 was not covered by tests
end

Expand Down Expand Up @@ -314,7 +314,7 @@ function set_tbl_col(
tmp::Bool = false,
show::Bool = false,
) where {T}
if (check_file(source) && length(name) == 0)
if check_file(source) && length(name) == 0
name = get_tbl_name(source, tmp)
end

Expand Down Expand Up @@ -350,7 +350,7 @@ function select(
src = fmt_source(con, source)
query = "SELECT * FROM $src WHERE $expression"

if (check_file(source) && length(name) == 0)
if check_file(source) && length(name) == 0
name = get_tbl_name(source, tmp)

Check warning on line 354 in src/pipeline.jl

View check run for this annotation

Codecov / codecov/patch

src/pipeline.jl#L353-L354

Added lines #L353 - L354 were not covered by tests
end

Expand Down

0 comments on commit 06d82e3

Please sign in to comment.