Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix option handling in pipeline.jl #70

Merged
merged 9 commits into from
Aug 9, 2024
Merged

Fix option handling in pipeline.jl #70

merged 9 commits into from
Aug 9, 2024

Commits on Aug 8, 2024

  1. pipeline.jl: wrap option handling in a function

    @suvayu
    suvayu committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    f1bc142 View commit details
    Browse the repository at this point in the history

  2. WIP: refactor using Val

    @suvayu
    suvayu committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    6d6f2b2 View commit details
    Browse the repository at this point in the history

  3. pipeline.jl: resolve the semantics of the options to set_tbl_col

    @suvayu
    suvayu committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    b7bf331 View commit details
    Browse the repository at this point in the history

  4. pipeline.jl: remove redundant codepath in _create_tbl_impl

    @suvayu
    suvayu committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    cbd9140 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Abel Soares Siqueira <[email protected]>
    @suvayu @abelsiqueira
    suvayu and abelsiqueira authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    40992ee View commit details
    Browse the repository at this point in the history

  2. pipeline.jl: docstring for get_tbl_name

    @suvayu
    suvayu committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    23e912e View commit details
    Browse the repository at this point in the history

  3. pipeline.jl: ensure automatic table name generation is tested always

    @suvayu
    suvayu committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    c91c0d4 View commit details
    Browse the repository at this point in the history

  4. test-pipeline.jl: isolate tests some more 

    - duplicate some lines to setup a table to isolate more tests
    @suvayu
    suvayu committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    3e91df5 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Abel Soares Siqueira <[email protected]>
    @suvayu @abelsiqueira
    suvayu and abelsiqueira authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    06d82e3 View commit details
    Browse the repository at this point in the history