Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiprecision unique coords detection to __from_ds__ #372

Merged

Conversation

philipc2
Copy link
Member

Closes #318

Overview

Changes to __from_ds function to include multi-precision

Expected Usage

import uxarray as ux

# Provide nodes that are extremely closed to each other
face_nodes_connectivity = [['1.000000000000000000', '1.000000000000000000001', '1.0000000000000000000012'],
 ['1.000000000000000001', '1.000000000000000000002', '1.0000000000000000000013']]

uxgrid =   ux.Grid(face_nodes_connectivity, multi_precision=True, precision= 65,
                        vertices=True,
                        islatlon=False,
                        concave=False)
print(uxgrid.nMesh2_face )# It will still detect two faces without degenration
>>> 2

# Perform any provided grid manipulation and then the results is precise up the the 65 bits

PR Checklist

General

  • An issue is linked created and linked
  • Add appropriate labels
  • Filled out Overview and Expected Usage (if applicable) sections

Testing

  • Adequate tests are created if there is new functionality
  • Tests cover all possible logical paths in your function
  • Tests are not too basic (such as simply calling a function and nothing else)

@philipc2 philipc2 changed the title Multiprecision unique coords detection to __from_ds` Multiprecision unique coords detection to __from_ds__` Jul 11, 2023
@aaronzedwick aaronzedwick changed the title Multiprecision unique coords detection to __from_ds__` Multiprecision unique coords detection to __from_ds__ Jul 11, 2023
@philipc2 philipc2 added the multiprecision Arbitrary-precision Arithmetic Implementations label Jul 12, 2023
@philipc2 philipc2 changed the base branch from multi_precision to main July 12, 2023 18:23
@philipc2 philipc2 changed the base branch from main to multi_precision July 12, 2023 18:23
@aaronzedwick aaronzedwick marked this pull request as ready for review July 21, 2023 15:10
@aaronzedwick
Copy link
Member

@hongyuchen1030 Could we get this merged if everything looks good?

Copy link
Contributor

@hongyuchen1030 hongyuchen1030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work!

@hongyuchen1030 hongyuchen1030 merged commit b97767e into multi_precision Jul 21, 2023
10 checks passed
@erogluorhan erogluorhan deleted the origin/aaronzedwick/from_ds_multi_precision branch August 11, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multiprecision Arbitrary-precision Arithmetic Implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multi-precision when initializing through Grid.__from_ds__()
3 participants