Fix item data handling order

ViaVersion · Jun 16, 2024 · 5f57041 · 5f57041
1 parent f91a25c
commit 5f57041
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/.../viaversion/viabackwards/protocol/v1_21to1_20_5/rewriter/BlockItemPacketRewriter1_21.java b/.../viaversion/viabackwards/protocol/v1_21to1_20_5/rewriter/BlockItemPacketRewriter1_21.java
@@ -47,7 +47,6 @@
 import com.viaversion.viaversion.rewriter.IdRewriteFunction;
 import java.util.ArrayList;
 import java.util.Arrays;
-import org.checkerframework.checker.nullness.qual.Nullable;
 
 import static com.viaversion.viaversion.protocols.v1_20_5to1_21.rewriter.BlockItemPacketRewriter1_21.downgradeItemData;
 import static com.viaversion.viaversion.protocols.v1_20_5to1_21.rewriter.BlockItemPacketRewriter1_21.updateItemData;
@@ -148,9 +147,10 @@ public Item handleItemToClient(final UserConnection connection, final Item item)
         enchantmentRewriter.rewriteEnchantmentsToClient(data, StructuredDataKey.ENCHANTMENTS, idRewriteFunction, descriptionSupplier, false);
         enchantmentRewriter.rewriteEnchantmentsToClient(data, StructuredDataKey.STORED_ENCHANTMENTS, idRewriteFunction, descriptionSupplier, true);
 
+        // Order is important
+        super.handleItemToClient(connection, item);
         downgradeItemData(item);
-
-        return super.handleItemToClient(connection, item);
+        return item;
     }
 
     @Override
@@ -170,9 +170,10 @@ public Item handleItemToServer(final UserConnection connection, final Item item)
         // Restore originals if present
         enchantmentRewriter.handleToServer(item);
 
+        // Order is important
+        super.handleItemToServer(connection, item);
         updateItemData(item);
-
-        return super.handleItemToServer(connection, item);
+        return item;
     }
 
     private void rewriteEnchantmentToServer(final EnchantmentsPaintingsStorage storage, final Item item, final StructuredDataKey<Enchantments> key) {