Skip to content

Commit

Permalink
Map wind charges to shulker bullets instead of llama spit
Browse files Browse the repository at this point in the history 
Spit has gravity by default and a short lifespan
Fixes #868
  • Loading branch information
@kennytv
kennytv committed Aug 15, 2024
1 parent 4f7acf2 commit 9ca5236
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ...viaversion/viabackwards/protocol/v1_20_3to1_20_2/rewriter/EntityPacketRewriter1_20_3.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,11 @@ public void onMappingDataLoaded() {
mapTypes();

mapEntityTypeWithData(EntityTypes1_20_3.BREEZE, EntityTypes1_20_3.BLAZE).jsonName();
mapEntityTypeWithData(EntityTypes1_20_3.WIND_CHARGE, EntityTypes1_20_3.LLAMA_SPIT).jsonName();
mapEntityTypeWithData(EntityTypes1_20_3.WIND_CHARGE, EntityTypes1_20_3.SHULKER_BULLET).jsonName();
}

@Override
public EntityType typeFromId(final int type) {
return EntityTypes1_20_3.getTypeFromId(type);
}
}
}

2 comments on commit 9ca5236

@HerobaneNair
Copy link

@HerobaneNair HerobaneNair commented on 9ca5236 Aug 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add some custom name to the shulker bullet so that resource packs can use custom entity models to add wind charges client side as well? Something like: wind_charge:1b would work

@HerobaneNair
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also since interaction entities exist, could you make an interaction entity on the shulker bullet that isn't hidden to the player but is interactable (like unrendered but still there). The dimensions would be 2.3 width/length/height cube centered on the windcharge/shulker bullet. This way it isn't 10x harder to hit/interact with the wind charge when on pre1.21

Please sign in to comment.