Handle data->pitch/yaw item frame rotation change in 1.17->1.16.4 #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older clients will ignore the data field and the server sets the item frame rotation by the yaw/pitch field inside the packet, newer clients do the opposite and ignore yaw/pitch and use the data field from the packet. Therefore, we need to restore that logic. Closes #843
FlorianMichael
added a commit
to ViaVersion/ViaVersion
that referenced
this pull request
Aug 2, 2024
kennytv
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older clients will ignore the data field and the server sets the item frame rotation by the yaw/pitch field inside the packet, newer clients do the opposite and ignore yaw/pitch and use the data field from the packet. Therefore, we need to restore that logic.
Closes #843