Remove transaction tracking (and cancelling) in 1.17->1.16.4 #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't see any reason why this would be required. Additionally, it also breaks duplicated ping packets being sent by the server since VB did not track how often an id is expected to be sent back.
kennytv
approved these changes
Sep 12, 2024
FlorianMichael
added a commit
to ViaVersion/ViaVersion
that referenced
this pull request
Sep 12, 2024
Should be the same as ViaVersion/ViaBackwards#883; There is no obvious reason for having the storage as MC would also just pass all packets (and the storage also breaks duplicates).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see any reason why this would be required. Additionally, it also breaks duplicated ping packets being sent by the server since VB did not track how often an id is expected to be sent back.