Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pom organization #223

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Add pom organization #223

merged 5 commits into from
Sep 20, 2024

Conversation

nnichols
Copy link
Member

Proposed Changes

  • Additions: Install Bouncer for project.clj checks
  • Updates: Fix the <organization> block in pom.xml
  • Deletions:

Pre-merge Checklist

  • Read and agree to the Contribution Guidelines and Code of Conduct
  • Write new tests for the changed functionality
  • Update CHANGELOG and increment version
  • Update README and relevant documentation

@nnichols nnichols requested a review from a team as a code owner September 20, 2024 16:27
@nnichols nnichols requested review from Dareknotderek and removed request for a team September 20, 2024 16:27
@WallBrewBot WallBrewBot added documentation Improvements or additions to documentation dependencies Updates to application dependency files source code Updates to the application or library source code clojure Clojure source code clojurescript ClojureScript source code labels Sep 20, 2024
@@ -2,23 +2,23 @@
"Default values for beer recipe generators")


(def ^:const common-beer-format-version 1)
(def common-beer-format-version 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[clj-kondo] reported by reviewdog 🐶
Missing docstring.


(def ^:const amount-cutoff 2.26796) ; 5 pounds in kilograms
(def amount-cutoff 2.26796) ; 5 pounds in kilograms
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[clj-kondo] reported by reviewdog 🐶
Missing docstring.


(def ^:const ingredient-amounts
(def ingredient-amounts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[clj-kondo] reported by reviewdog 🐶
Missing docstring.

[0.01 0.025 0.05 0.075 0.1])


(def ^:const minimum-ingredient-amount
(def minimum-ingredient-amount
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[clj-kondo] reported by reviewdog 🐶
Missing docstring.

(apply min ingredient-amounts))


(def ^:const hop-times
(def hop-times
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[clj-kondo] reported by reviewdog 🐶
Missing docstring.

@@ -54,31 +54,31 @@
1 20.0})


(def ^:const bittering-hop-use-weights
(def bittering-hop-use-weights
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[clj-kondo] reported by reviewdog 🐶
Missing docstring.

{"boil" 200.0
"dry hop" 20.0
"mash" 40.0
"first wort" 40.0
"aroma" 10.0})


(def ^:const aroma-hop-use-weights
(def aroma-hop-use-weights
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[clj-kondo] reported by reviewdog 🐶
Missing docstring.

{"boil" 200.0
"dry hop" 80.0
"mash" 10.0
"first wort" 10.0
"aroma" 40.0})


(def ^:const both-hop-use-weights
(def both-hop-use-weights
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[clj-kondo] reported by reviewdog 🐶
Missing docstring.

{"boil" 200.0
"dry hop" 80.0
"mash" 10.0
"first wort" 10.0
"aroma" 10.0})


(def ^:const common-beer-format-default-mash
(def common-beer-format-default-mash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[clj-kondo] reported by reviewdog 🐶
Missing docstring.

@@ -90,7 +90,7 @@
:infuse-amount 10.0}}]})


(def ^:const common-beer-format-recipe-defaults
(def common-beer-format-recipe-defaults
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[clj-kondo] reported by reviewdog 🐶
Missing docstring.

@nnichols nnichols merged commit 75b0f22 into master Sep 20, 2024
13 checks passed
@nnichols nnichols deleted the add-pom-organization branch September 20, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clojure Clojure source code clojurescript ClojureScript source code dependencies Updates to application dependency files documentation Improvements or additions to documentation source code Updates to the application or library source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants