fix: profiles options, add numeric step input for layout, align icons… #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckifer
commented
Jul 13, 2023
ckifer
commented
- remove default props eslint rule - don't need with TS
- add breakpoints to make settings boxes more responsive
- move common styles to constants
- numeric step input
- use grid to align items and props to allow change functions to be sent
- super basic placeholder state
- fix profile menu items
|
We have a lot of conflicts with my changes in the other PR I've already fixed the settings layout and made settings functional. Also made it responsive for mobile (making Tab bar horizontal and positioning settings underneath). Think we can close your PR or you can move furterh improvements on top of my branch? |
|
Oh nice I didn't even notice yours 😅. Sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.