-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ts): network components to ts, fix typo #507
Conversation
@kstam having issues connecting to wifi after your recent changes - everything else works (if password was previously saved it works)
|
You mean it's still not working after your changes? Just checking, have you flushed the latest webserver on the ESP too? The connection API was changed from Multipart data to JSON. But that was a while back 🤔 I'll also check on my side in case I accidentally f'ed up something? |
Right - on every change I'll flash the webserver. After the change from multipart to JSON (it seems at least) I can no longer connect with ssid and password. I had connected previously and had my network saved so I don't think I tested after that change. The request gets sent to the webserver fine it's something in the call it seems. (But could be me) |
Can you try this fix? I can't reproduce it locally but it might be that my WiFI connection is stronger so the WDT doesn't kill my ESP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
that did it - thanks! |
loading
from dependency array so network call is only made onceTesting