Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ts): network components to ts, fix typo #507

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

ckifer
Copy link

@ckifer ckifer commented Jul 15, 2023

  • typo + some small font adjustments
  • refactor network components to TS
  • fix bug where network drawer would continually refresh and not stop
    • remove loading from dependency array so network call is only made once

Testing

  • connect to wifi -> disconnect from wifi
  • network settings results and flow remain the same

@ckifer
Copy link
Author

ckifer commented Jul 15, 2023

@kstam having issues connecting to wifi after your recent changes - everything else works (if password was previously saved it works)

I (wifi_setup.cpp:97): Connecting to WiFi [airCube-6C5]
E (476294) task_wdt: Task watchdog got triggered. The following tasks did not reset the watchdog in time:
E (476294) task_wdt:  - async_tcp (CPU 1)
E (476294) task_wdt: Tasks currently running:
E (476294) task_wdt: CPU 0: IDLE
E (476294) task_wdt: CPU 1: IDLE
E (476294) task_wdt: Aborting.

abort() was called at PC 0x42036468 on core 0


Backtrace: 0x4037733a:0x3fc98830 0x4037f001:0x3fc98850 0x403851cd:0x3fc98870 0x42036468:0x3fc988f0 0x403787bd:0x3fc98910 0x4212b433:0x3fcf56f0 0x42036ccd:0x3fcf5710 0x40380594:0x3fcf5730

ELF file SHA256: b7492f39c4e20297

Rebooting...
␀�ESP-ROM:esp32s3-20210327
Build:Mar 27 2021
rst:0xc (RTC_SW_CPU_RST),boot:0x8 (SPI_FAST_FLASH_BOOT)
Saved PC:0x40376f48
SPIWP:0xee
mode:DIO, clock div:1
load:0x3fce3808,len:0x44c
load:0x403c9700,len:0xbe4
load:0x403cc700,len:0x2a38
entry 0x403c98d4

@kstam
Copy link
Collaborator

kstam commented Jul 16, 2023

You mean it's still not working after your changes?

Just checking, have you flushed the latest webserver on the ESP too? The connection API was changed from Multipart data to JSON. But that was a while back 🤔

I'll also check on my side in case I accidentally f'ed up something?

@ckifer
Copy link
Author

ckifer commented Jul 16, 2023

Right - on every change I'll flash the webserver. After the change from multipart to JSON (it seems at least) I can no longer connect with ssid and password. I had connected previously and had my network saved so I don't think I tested after that change.

The request gets sent to the webserver fine it's something in the call it seems. (But could be me)

@kstam
Copy link
Collaborator

kstam commented Jul 16, 2023

Can you try this fix?
https://github.com/Zer0-bit/gaggiuino/pull/509/files

I can't reproduce it locally but it might be that my WiFI connection is stronger so the WDT doesn't kill my ESP

Copy link
Collaborator

@kstam kstam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zer0-bit Zer0-bit merged commit cc1a30d into Zer0-bit:dev Jul 16, 2023
4 of 7 checks passed
@ckifer ckifer deleted the refactor/network-ts branch July 16, 2023 17:28
@ckifer
Copy link
Author

ckifer commented Jul 16, 2023

Can you try this fix? https://github.com/Zer0-bit/gaggiuino/pull/509/files

I can't reproduce it locally but it might be that my WiFI connection is stronger so the WDT doesn't kill my ESP

that did it - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants