Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Settings.IsHostedServer value consistent with UrlUtil.IsHostedServer #3326

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make Settings.IsHostedServer value consistent with UrlUtil.IsHostedServer #3326

wants to merge 1 commit into from

Commits on Jun 10, 2024

  1. Make Settings.IsHostedServer value consistent with UrlUtil.IsHostedSe… 

    …rver

When running GitHub Enterprise Server with a pool of JIT-configured runners (such as what [philips-labs/terraform-aws-github-runner](https://github.com/philips-labs/terraform-aws-github-runner/) provides), actions#1199 still occurs. The fix in actions#1291 uses the "IsHostedServer" property from the settings which is **not** set by the GHES endpoint for JIT configuration.

This change computes the default value of IsHostedServer from the GitHub server URL, as is already done in [lots of other parts of the code](https://github.com/search?q=repo%3Aactions%2Frunner%20IsHostedServer&type=code) to make it consistent.
    @alixinne
    alixinne committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    a97d6ac View commit details
    Browse the repository at this point in the history