Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Up Next integration #138

Merged
merged 1 commit into from
Feb 16, 2020
Merged

Implement Up Next integration #138

merged 1 commit into from
Feb 16, 2020

Conversation

michaelarnauts
Copy link
Collaborator

This PR implements Up Next integration.

Fixes #49

@michaelarnauts
Copy link
Collaborator Author

@dagwieers could you check if this works fine for you?

@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #138 into master will increase coverage by 0.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   79.53%   80.29%   +0.75%     
==========================================
  Files          23       23              
  Lines        2253     2365     +112     
==========================================
+ Hits         1792     1899     +107     
- Misses        461      466       +5     
Impacted Files Coverage Δ
resources/lib/modules/player.py 88.40% <0.00%> (-1.18%) ⬇️
resources/lib/vtmgo/vtmgostream.py 81.31% <0.00%> (-1.34%) ⬇️
resources/lib/vtmgo/vtmgoepg.py 93.57% <0.00%> (+0.05%) ⬆️
test/xbmcaddon.py 96.00% <0.00%> (+0.34%) ⬆️
resources/lib/kodiwrapper.py 74.40% <0.00%> (+1.48%) ⬆️
resources/lib/vtmgo/vtmgo.py 78.24% <0.00%> (+0.53%) ⬆️
resources/lib/plugin.py 91.45% <0.00%> (+1.97%) ⬆️
test/xbmc.py 67.76% <0.00%> (+4.13%) ⬆️
test/xbmcgui.py 70.22% <0.00%> (+4.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d40736e...ec34388. Read the comment docs.

@@ -367,18 +367,34 @@ msgctxt "#30861"
msgid "Subtitles"
msgstr ""

msgctxt "#30863"
msgctxt "#30862"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason to skip one number is that in the future the settings will allow to add a help-text.
So we have these numbers already preserved for the future.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember seeing this in Kodi 19. When is this expected?

I didn't want to rename all other items, so I just used the other numbers.

Copy link
Collaborator

@dagwieers dagwieers Feb 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It already works in Kodi 18, you can use the new settings format. But there were still minor issues and the Kodi devs did not recommend using it.

Check: xbmc/addon-check#127

Copy link
Collaborator

@dagwieers dagwieers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

I noticed you used the Example source code, which I have simplified from the kodiutils we use.
E.g. our jsonrpc call supports batch processing, while the one on the Wiki has this omitted.

@dagwieers
Copy link
Collaborator

Works well. It is nice to see this implemented using the example source code :-)

@michaelarnauts michaelarnauts merged commit 3b2bc0e into master Feb 16, 2020
@michaelarnauts michaelarnauts deleted the upnext branch February 16, 2020 20:16
@michaelarnauts michaelarnauts added the enhancement New feature or request label Feb 16, 2020
@dagwieers dagwieers modified the milestones: v0.9.3, v0.9.4 Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for "Up Next"
2 participants