-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Up Next integration #138
Conversation
@dagwieers could you check if this works fine for you? |
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
==========================================
+ Coverage 79.53% 80.29% +0.75%
==========================================
Files 23 23
Lines 2253 2365 +112
==========================================
+ Hits 1792 1899 +107
- Misses 461 466 +5
Continue to review full report at Codecov.
|
@@ -367,18 +367,34 @@ msgctxt "#30861" | |||
msgid "Subtitles" | |||
msgstr "" | |||
|
|||
msgctxt "#30863" | |||
msgctxt "#30862" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason to skip one number is that in the future the settings will allow to add a help-text.
So we have these numbers already preserved for the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember seeing this in Kodi 19. When is this expected?
I didn't want to rename all other items, so I just used the other numbers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It already works in Kodi 18, you can use the new settings format. But there were still minor issues and the Kodi devs did not recommend using it.
Check: xbmc/addon-check#127
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
I noticed you used the Example source code, which I have simplified from the kodiutils we use.
E.g. our jsonrpc
call supports batch processing, while the one on the Wiki has this omitted.
Works well. It is nice to see this implemented using the example source code :-) |
This PR implements Up Next integration.
Fixes #49