Separate Small and Large Oil Rig notification settings #339
Conversation
|
Due to the removal of the existing generic Oil Rig notification settings to make them more specific, this PR, as it exists causes an issue when the user updates their existing installation, as they will have a notification setting key in their instance file which no longer exists, and an exception will be thrown. I've resolved this issue (on a separate branch) with commit 1b83863 which I'm happy to merge into this PR, but I’ve left it out for now in case the PR reviewer dislikes that approach 😁 |
|
(Fixed a couple of missed translations with a force push to keep the PR as one commit) |
|
I like that change but one thing you have to change is the lang files. we only translate into english and all other languages are updated by crowdin. so you have to remove that from your commits |
|
All done, thanks for letting me know!
Do you have any thoughts on this? Should I add this change to the PR, or do you have another idea/approach? |
alexemanuelol
force-pushed
the
master
branch
from
a5d6956
to
881faa2
Compare
This allows independently setting Small and Large Oil Rig notifications for Heavy Scientists and Locked Crate unlocks.